char-server crash, very recent commit

[AnnieRuru]

Issue Prelude

• I have not modified the source prior to reproducing this issue.
• I am using the latest version of Hercules.
• I am aware that this report will be closed or deleted if it becomes obvious that I am stating the false.

AND I have disable ALL my plugins, no plugins and no source modifications

Description

core dump from visual studio ->

Autos

	Name	Value	Type
▶	buf	0x0018b274 "58\x1"	unsigned char[23]
▶	g	0x02a3a8bc {guild_id=1 guild_lv=50 connect_member=0 ...}	guild *
▶	g->member	0x02a3a90c {{account_id=2000000 char_id=150000 hair=3 ...}, {account_id=2000002 char_id=150002 hair=...}, ...}	guild_member[76]
▶	g->member[idx]	{account_id=2000000 char_id=150000 hair=3 ...}	guild_member
	g->member[idx].last_login	1549865090	unsigned int
	idx	0	int
▶	mapif	0x006d7cf8 {char-server.exe!mapif_interface mapif_s} {ban=0x00574cb0 {char-server.exe!mapif_ban(int, unsigned int, int)} ...}	mapif_interface *
	mapif->sendall	0x005850d0 {char-server.exe!mapif_sendall(const unsigned char *, unsigned int)}	int(*)(const unsigned char *, unsigned int)

Call Stack

 	char-server.exe!failwithmessage(void * retaddr, int crttype, int errnum, const char * msg) Line 213	C++
 	char-server.exe!_RTC_StackFailure(void * retaddr, const char * varname) Line 261	C++
 	char-server.exe!_RTC_CheckStackVars(void * frame, _RTC_framedesc * v) Line 77	C++
>	char-server.exe!mapif_guild_memberinfoshort(guild * g, int idx) Line 585	C
 	char-server.exe!inter_guild_update_member_info_short(int guild_id, int account_id, int char_id, int online, int lv, int class) Line 1081	C
 	char-server.exe!mapif_parse_GuildChangeMemberInfoShort(int fd, int guild_id, int account_id, int char_id, int online, int lv, int class) Line 802	C
 	char-server.exe!inter_guild_parse_frommap(int fd) Line 1605	C
 	char-server.exe!inter_parse_frommap(int fd) Line 1139	C
 	char-server.exe!char_parse_frommap(int fd) Line 4114	C
 	char-server.exe!do_sockets(int next) Line 1072	C
 	char-server.exe!main(int argc, char * * argv) Line 538	C
 	[External Code]	
 	[Frames below may be incorrect and/or missing, no symbols loaded for kernel32.dll]	Unknown
 	char-server.exe!__acrt_LCMapStringW(const wchar_t * locale_name, unsigned long map_flags, const wchar_t * source, int source_count, wchar_t * destination, int destination_count) Line 53	C++

Current Behavior

Char-server crash whenever I login a character

Expected Behavior

don't crash, of course

Steps To Reproduce The Issue

1. launch Hercules by run-server.bat
2. login my character
3. bam, char-server crash

Branch(es):

• master

Hercules rev. hash/commit: & Operating System

LATEST hash, means this comes from one of the last 3 commit Haru just merge
PACKEVER 20180620 RE

[Asheraf]

@4144 looks like you forgot to increase the buffer size in mapif_guild_memberinfoshort, it should be 25 now.

[4144]

fixed buffer size thanks,
and some other minor issues

[4144]

@AnnieRuru can you check is issue fixed?