Fixes #1655 - Fix to Sura Job Change Quest get stuck after first attemp. #1656
Conversation
| mapwarp "sword_2-1","yuno_fild07",255,178; | ||
| donpcevent "#Sura_garajjom::OnDisable"; | ||
| donpcevent "Drawing Room::OnEnable"; | ||
| // donpcevent "#Sura_garajjom::OnDisable"; |
There was a problem hiding this comment.
Why comment and not remove these 2 lines?
There was a problem hiding this comment.
I tried to be the less invasive possible with the script, I comment the line instead of removing it because it is intended to be there (I did comparison with official script), but having it allows player to always success the test.
However, if should be removed, I can remove it without any problem :)
There was a problem hiding this comment.
if those lines would be commented maybe should add a comment on them that explain why, otherwise if someone in the future compared the script with official one its may be confusing.
There was a problem hiding this comment.
Done. Applied comment to explain that.
There was a problem hiding this comment.
@iRagno If the behaviour of it always succeeding is not official then the old lines should be removed rather than commented.
There was a problem hiding this comment.
yeah this is not official.. we should check whats wrong with it
There was a problem hiding this comment.
yeah this is not official.. we should check whats wrong with it
…first attemp. Signed-off-by: Ragno <[email protected]>
AtlantisRO
force-pushed
the
job_quest_sura
branch
from
4600797 to
d347a6c
Compare
|
@iRagno any update? |
dastgirp
added
component:scripts
7 participants
Pull Request Prelude
Changes Proposed
Fixes following Sura job change quest issues:
a) Player will not be able to success the test if fail it (die in test).
b) Waiting room will not get stuck anymore after the first attemp of the quest.
For more details, please read issue.
Affected Branches:
masterIssues addressed:
Known Issues and TODO List
None
This change is