Fix map-server crash when using npcspeed on a npc not on a map

[chriser-]

Pull Request Prelude

• I have followed proper Hercules code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Check for unit data (nd->ud != NULL) before adjust the NPC speed.
Throw warnings if nd->ud == NULL.

Issues addressed:
Prevent map-server from crashing when adjust the NPC speed.

Sample NPC Script:

-	script	dummynpc	-1,{
	OnInit:
		debugmes "set speed to 100";
		npcspeed 100;
		debugmes "set speed done";
		end;
}

Result:

After fixed: throw warnings but didnt crash map-server

[HerculesWSAPI]

This change is 

[4144]

Probably better show error message and not silently ignore it?

[Emistry]

resolved.

[Emistry]

btw, how do I add the co-author back to the commit message? cant seem to find the author email.

Co-authored-by: name <[email protected]>

@chriser- is this right ?

Details

EDIT -- after i update the fork it became 2 commits, should I squash it together? does anything in the merge commit would break this PR?

EDIT2--
this seem fixed messed up commits for me.

git reset <commit-hash>
git reset --hard
git push --force

[4144]

nd and speed vars better use in same line with defining.
For example for nd:
struct npc_data *nd = map->id2nd(st->oid);

[4144]

also need rebase

[4144]

about coauthor, you can add anything into commit messages
if you have one commit only, can use git commit --amend
or use interactive rebase and change line for commit from pick to reword

[chriser-]

If it is easier, you can just re-do the fix in master and commit it under your own name.
As long as this contribution helps, I don't care if it is merged using my commit or your own.

[Emistry]

closing this due to the commits are actually done in master branch which later become troublesome to fix/solve the conflicts. Reopen a new PR here.

[MrKeiKun]

anyone wants to remove this from Stalled / Forgotten in Project Board?