Skip to content

add buildin_getmapinfo #1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Helianthella merged 2 commits into from
Oct 20, 2017
Merged

add buildin_getmapinfo #1852

Helianthella merged 2 commits into from
Oct 20, 2017

Conversation

@Helianthella
Copy link
Member

@Helianthella Helianthella commented Oct 5, 2017

Pull Request Prelude

Changes Proposed

New buildin: getmapinfo()
Allows to get misc info about a map

@Helianthella Helianthella added component:core:scriptengine Affecting the script engine or the script commands component:documentation Affecting the documentation in the doc/ folder type:enhancement Issue describes an enhancement or feature that should be implemented labels Oct 5, 2017
@ghost ghost assigned Helianthella Oct 5, 2017
@ghost ghost added the status:inprogress Issue is being worked on / the pull request is still a WIP label Oct 5, 2017
@HerculesWSAPI
Copy link
Contributor

HerculesWSAPI commented Oct 5, 2017

This change is Reviewable

@Helianthella Helianthella removed the status:inprogress Issue is being worked on / the pull request is still a WIP label Oct 5, 2017
@ghost ghost added the status:inprogress Issue is being worked on / the pull request is still a WIP label Oct 5, 2017
@Helianthella Helianthella removed the status:inprogress Issue is being worked on / the pull request is still a WIP label Oct 5, 2017
@ghost ghost added the status:inprogress Issue is being worked on / the pull request is still a WIP label Oct 5, 2017
@Helianthella Helianthella removed the status:inprogress Issue is being worked on / the pull request is still a WIP label Oct 5, 2017
@Helianthella Helianthella added this to the next release milestone Oct 8, 2017
@MishimaHaruna MishimaHaruna added the codereview:accepted Code review was positive and the pull request can be accepted as is label Oct 17, 2017
@Helianthella Helianthella merged commit 04f10f3 into HerculesWS:master Oct 20, 2017
@Helianthella Helianthella deleted the getmapinfo2 branch October 20, 2017 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dastgirp dastgirp dastgirp approved these changes

@MishimaHaruna MishimaHaruna MishimaHaruna approved these changes

Assignees

@Helianthella Helianthella

Labels

codereview:accepted Code review was positive and the pull request can be accepted as is component:core:scriptengine Affecting the script engine or the script commands component:documentation Affecting the documentation in the doc/ folder type:enhancement Issue describes an enhancement or feature that should be implemented

Projects

None yet

Milestone

Release v2017.10.22

Development

Successfully merging this pull request may close these issues.

4 participants

@Helianthella @HerculesWSAPI @dastgirp @MishimaHaruna