Skip to content

Conversation

@iRagno
Copy link
Contributor

@iRagno iRagno commented Oct 22, 2017

Pull Request Prelude

Changes Proposed

Applied a few changes to fit script with official one and applied standardization to entire script.

Affected Branches: Master

Issues addressed: None

Known Issues and TODO List

…Standards.

- Added mesf and sprintf commands where needed.
- Added _$() and _() macros where needed.
- Added curly brackets, paragraph breaks, parentheses and spaces to fit Hercules' Standards.
- Changed numeric arguments for constants.

Signed-off-by: Ragno <[email protected]>
@ghost ghost added the status:code-review Awaiting code review label Oct 22, 2017
@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@Asheraf Asheraf added component:scripts Affecting the scripts and NPCs mode:renewal For strictly Renewal issues labels Oct 22, 2017
@Asheraf Asheraf changed the base branch from stable to master October 26, 2017 12:32
@Asheraf Asheraf merged commit f913fd8 into HerculesWS:master Oct 29, 2017
@ghost ghost removed the status:code-review Awaiting code review label Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:scripts Affecting the scripts and NPCs mode:renewal For strictly Renewal issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants