Applied standardization to saras_memory script #1884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Contributor
|
This change is |
Asheraf
reviewed
Oct 22, 2017
npc/re/instances/saras_memory.txt
Outdated
| next; | ||
| donpcevent(instance_npcname("Doyen Irene#sarains")+"::OnDisable"); | ||
| donpcevent(instance_npcname("A girl#sarains")+"::OnDisable"); | ||
| dispbottom(_("As they wander off you hear strange voices from around the corner...")), ""; |
Contributor
Author
There was a problem hiding this comment.
Done. Thank you Asheraf.
Asheraf
added
component:scripts
Asheraf
reviewed
Oct 26, 2017
npc/re/instances/saras_memory.txt
Outdated
| dali,130,107,5 script Leon the Adventurer#Sara 4_M_DST_GRAND,{ // instance CD check only at the Dimensional Device | ||
| mes("[Leon the Adventurer]"); | ||
| if (BaseLevel < 99) { | ||
| mes("You know... this place doesn't seem to be safe for you. Please returnto me once you have achieved LV. 99"); |
Contributor
There was a problem hiding this comment.
please correct this one return to
Contributor
Author
There was a problem hiding this comment.
Done. Just for the record, this was only focused on standardization, but I guess can also add typo fixes.
Contributor
|
As for the changes in PR it looks good to me, but we should take into consideration merging the npc's with same functionality into one and using the duplicate function |
…Standards. - Added mesf and sprintf commands where needed. - Added _$() and _() macros where needed. - Added curly brackets, paragraph breaks, parentheses and spaces to fit Hercules' Standards. - Changed numeric arguments for constants. Signed-off-by: Ragno <[email protected]>
AtlantisRO
force-pushed
the
Standardization-saras_memory.txt
branch
from
62fec82 to
683c604
Compare
Contributor
Author
|
Applied requested changes and squashed commits. I saw the script can be improved in several parts, like duplicating npcs that are identical.. But, this was only fixing standardization to the script, and leaved any structural change for the future. |
Asheraf
approved these changes
Oct 27, 2017
dastgirp
approved these changes
Oct 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Applied a few changes to fit script with official one and applied standardization to entire script.
Affected Branches:
MasterIssues addressed:
NoneKnown Issues and TODO List