implement homunculus autofeeding for 2017 clients #1898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
status:inprogress
Contributor
|
This change is |
Asheraf
added
status:code-review
Asheraf
force-pushed
the
homunaf
branch
2 times, most recently
from
f435057 to
2ea00d5
Compare
4144
requested changes
Nov 5, 2017
Contributor
4144
left a comment
4144
left a comment
There was a problem hiding this comment.
Please update also main.sql with new field and updates list
4144
approved these changes
Nov 5, 2017
Asheraf
force-pushed
the
homunaf
branch
2 times, most recently
from
7a8c0d8 to
5283e5e
Compare
Asheraf
added
the
type:enhancement
dastgirp
approved these changes
Nov 13, 2017
Member
|
What do you think about adding a battle_config pref to optionally disable this (it's fine if it's enabled by default)? |
Asheraf
force-pushed
the
homunaf
branch
2 times, most recently
from
27503b7 to
e38cb92
Compare
Contributor
Author
|
@MishimaHaruna done. |
MishimaHaruna
modified the milestones:
Release v2017.11.19,
future release,
Release v2017.12.17
Lemongrass3110
added a commit
to rathena/rathena
that referenced
this pull request
Mar 26, 2018
This feature is available in 2017-09-20bRagexeRE or later Credits to @Asheraf in HerculesWS/Hercules#1898
secretdataz
pushed a commit
to rathena/rathena
that referenced
this pull request
Apr 4, 2018
* Added support for homunculus autofeeding This feature is available in 2017-09-20bRagexeRE or later Credits to @Asheraf in HerculesWS/Hercules#1898
CrazyBS
pushed a commit
to CrazyBS/rathena
that referenced
this pull request
Apr 16, 2018
* Added support for homunculus autofeeding This feature is available in 2017-09-20bRagexeRE or later Credits to @Asheraf in HerculesWS/Hercules#1898
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Affected Branches:
master
Known Issues and TODO List
non