-
Notifications
You must be signed in to change notification settings - Fork 772
Adds configuration for Magic Rod behavior (official/eAthena). #2034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dastgirp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although the PR looks good, maybe @4144 or @MishimaHaruna need to decide whether to add this old behavior or not.
|
Re-did PR hoping it gets approved this time 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested in-game already, works perfectly fine
accidentally press self review button hahaha
|
I don't mind the comment, but the contact name might be misleading |
|
That's me. It's a habit when I am editing src to comment my name. I will remove it. |
Pull Request Prelude
Changes Proposed
Adds a battleconf option for Magic Rod behavior, allowing a choice between official and old eAthena.
Affected Branches:
Master.
Issues addressed:
None.