Skip to content

Conversation

@bWolfie
Copy link
Contributor

@bWolfie bWolfie commented May 7, 2018

Pull Request Prelude

Changes Proposed

Adds a battleconf option for Magic Rod behavior, allowing a choice between official and old eAthena.

  • Official: Every time you use the Magic Rod skill, the animation will occur.
  • eAthena: The animation for Magic Rod will only occur when you absorb a spell.

Affected Branches:

Master.

Issues addressed:

None.

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

Copy link
Member

@dastgirp dastgirp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the PR looks good, maybe @4144 or @MishimaHaruna need to decide whether to add this old behavior or not.

@bWolfie
Copy link
Contributor Author

bWolfie commented Feb 27, 2019

Re-did PR hoping it gets approved this time 😀

@Asheraf Asheraf added this to the Release v2019.03.10 milestone Feb 27, 2019
Copy link
Contributor

@AnnieRuru AnnieRuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in-game already, works perfectly fine

accidentally press self review button hahaha

@AnnieRuru AnnieRuru self-requested a review February 27, 2019 15:02
@AnnieRuru
Copy link
Contributor

AnnieRuru commented Feb 27, 2019

// Animation used here in official [Wolfie]
who is the person call Wolfie ?

I don't mind the comment, but the contact name might be misleading

@bWolfie
Copy link
Contributor Author

bWolfie commented Feb 28, 2019

That's me. It's a habit when I am editing src to comment my name. I will remove it.

@MishimaHaruna MishimaHaruna merged commit af3bf18 into HerculesWS:master Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants