Updated message on char-server #2151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This change is |
dastgirp
added
type:enhancement
MishimaHaruna
requested changes
Sep 23, 2018
| static int char_parse_fromlogin_connection_state(int fd) | ||
| { | ||
| if (RFIFOB(fd,2)) { | ||
| switch (RFIFOB(fd,2)) { |
Member
There was a problem hiding this comment.
What do you think about adding a default: case here, to catch any other values (futureproofing, or customized login server error codes)?
… when IP is not allowed Updated char-server to show proper error message. Fixes HerculesWS#737 Signed-off-by: Haru <[email protected]>
MishimaHaruna
force-pushed
the
login/message
branch
from
85aa299 to
dd50f75
Compare
MishimaHaruna
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Char server will show proper message is IP is not allowed to connect.
Affected Branches:
Issues addressed:
#737
Known Issues and TODO List