Moved hardcoded messages to conf #2152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This change is |
dastgirp
force-pushed
the
clif_messages
branch
2 times, most recently
from
a0e6a09 to
7091870
Compare
dastgirp
added
type:enhancement
dastgirp
force-pushed
the
clif_messages
branch
from
7091870 to
0a84f31
Compare
dastgirp
force-pushed
the
clif_messages
branch
from
0a84f31 to
704d031
Compare
4144
approved these changes
Oct 13, 2018
dastgirp
force-pushed
the
clif_messages
branch
from
704d031 to
b7b3080
Compare
Member
Author
|
Conflicts Fixed |
4144
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Some of the strings were hardcoded in the source,
moved them to messages.conf
Affected Branches:
Issues addressed:
#1282
Known Issues and TODO List
Let me know if there are any more missing messages