Skip to content

Conversation

@dastgirp
Copy link
Member

@dastgirp dastgirp commented Aug 7, 2018

Pull Request Prelude

Changes Proposed

Configuration to enable/disable achievement system database loading and validation.

Affected Branches:

Issues addressed:

Known Issues and TODO List

@dastgirp dastgirp requested a review from Asheraf August 7, 2018 13:34
@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@dastgirp dastgirp added component:other Any issues that don't fall in the explicitly described components status:code-review Awaiting code review labels Aug 7, 2018
@kyeme
Copy link

kyeme commented Aug 9, 2018

I disable the system and try to login I got this error and map crashed.
1

@dastgirp
Copy link
Member Author

dastgirp commented Aug 9, 2018

Ah, it seems more checks are needed in case the user already have achievement

@HezekiahZratinel
Copy link

HezekiahZratinel commented Sep 16, 2018

im getting that error too.. and i also try to create a new account and this error Untitled shows up and the server automatically restart on its own..

@MishimaHaruna MishimaHaruna added this to the Release v2018.10.21 milestone Sep 23, 2018
@shadow-mo0n
Copy link

Still getting an map crash..
capture
capture1

@4144
Copy link
Contributor

4144 commented Sep 28, 2018

look like you have already assigned achievements in sql db. but hercules not read achievements from configuration files. from here many errors in console.
crash probably because missing init code

@shadow-mo0n
Copy link

Im not actually using this Achievement System. I added this code in my server to disable the system. Also my achievements_db is on default.
I think the check in libconfig files is causing the crash. It should be always be loaded even if you set the feature_enable_achievement to false.

@MishimaHaruna MishimaHaruna force-pushed the feature/achievement-config branch from 7fa9646 to cd32aea Compare April 7, 2019 16:02
@MishimaHaruna MishimaHaruna merged commit 4c7057a into HerculesWS:master Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:other Any issues that don't fall in the explicitly described components status:code-review Awaiting code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants