Mapflag nostorage and nogstorage

[carloshenrq]

Pull Request Prelude

• I have followed proper Hercules code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR will be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

This pull request, add 2 new mapflags by default. nostorage and nogstorage.
This change only affect atcommands like @storage and @gstorage, NPCs are still able to open player storage.

By now, we can apply this using plugins, but i believe this flag can be default in hercules.

Affected Branches:

master

Issues addressed:

Known Issues and TODO List

[HerculesWSAPI]

This change is 

[4144]

please squash all commits, because fix commits is useless until not pushed to master

[carloshenrq]

@4144 Thank you for explain and be clear. I'm new in pull requests... Anyway, i've combined them in one commit.

[carloshenrq]

@4144 Hi! Can you review this? Thank you =]

[4144]

@carloshenrq probably same flags need check also in script commands related to storages?

[carloshenrq]

@4144 Actually I don't think it should be needed. There're some servers that set @storage for VIP players... but inside battlegrounds, for example, this might be blocked to prevent abuse... Anyway, I can put a type in the mapflag... like:

prontera mapflag nostorage 1 // block only atcommands
prontera mapflag nostorage 2 // block only script commands
prontera mapflag nostorage 3 // block atcommands and script commands

but the block de script commands'll be last used.

[Asheraf]

Isn't this doable via the map zone db, and it's much more configurable since you can set any command not just the storage and you can specify a group id to bypass the restriction.. other than that if you're still adding this i would suggest renaming it to noatstorage noatgstorage since that is a more accurate naming.

[4144]

yes probably type can be good idea

[carloshenrq]

@4144 i've added the types and as @Asheraf says, added a group permission to bypass the flag. Can't test it now, but it's done.

[carloshenrq]

@4144 Ok! I'll change =]

Just for record... I've copied and pasted from others mapflags like this one: (refer to if( !state )) and %s", params)

} else if ( !strcmpi(flag,"long_damage_rate") ) {
	if( !state ) {
		if( map->list[m].long_damage_rate != 100 ) {
			sprintf(rflag,"long_damage_rate\t%d",map->list[m].long_damage_rate);
			map_zone_mf_cache_add(m,rflag);
		}
	} if( sscanf(params, "%d", &state) == 1 ) {
		if( state != map->list[m].long_damage_rate ) {
			sprintf(rflag,"long_damage_rate\t%s",params);
			map_zone_mf_cache_add(m,rflag);
		}
	}
} else if (!strcmpi(flag,"nocashshop")) {

Should be an issue/task for change others to new format?

[4144]

yes in code many wrong style. but in new code better not add more style issues.

about task yes, probably some one should fix style issues

[carloshenrq]

@4144 Have done all changes! Can you review it? Thank you =]

[carloshenrq]

@dastgirp and @4144 All changes are done.

[carloshenrq]

@4144 and @dastgirp can you guys review it again? Thank you =]