Skip to content

Conversation

@Helianthella
Copy link
Member

@Helianthella Helianthella commented Sep 21, 2018

Pull Request Prelude

Changes Proposed

This is a follow-up to http://herc.ws/board/topic/16318-cant-connect-to-mysql-server-on-127001/#comment-89417

  • Adds a scoop-based automatic installer for MariaDB

@Helianthella Helianthella added type:enhancement Issue describes an enhancement or feature that should be implemented component:other Any issues that don't fall in the explicitly described components component:SQL Affecting the SQL databases component:documentation Affecting the documentation in the doc/ folder labels Sep 21, 2018
@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

- Import the .sql files in /sql-files/ into the new database.
5. Start Visual Studio and load the provided solution:
3. Run mariadb.bat to automatically install and configure MariaDB.
4. Start Visual Studio and load the provided solution:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could even reduce this further to a single command

powershell -ExecutionPolicy Bypass -Command "iex ((New-Object System.Net.WebClient).DownloadString('https://rawgit.com/HerculesWS/Hercules/stable/install.ps1'))"

We could make said command do the following:

  • Install scoop,
  • Install git
  • Install MariaDB
  • Install Visual Studio
  • Clone Hercules
  • Configure MariaDB
  • Compile Hercules

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

power shell probably better leave as optional command
because not all windows may have and support powershell.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

powershell is present since XP SP2, and XP and Vista aren't even supported anymore and 7 is only still supported in business editions

we can safely rely on powershell

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i not have poweshell in xp sp3, but probably it can be installed.
not sure is other windows is powershell optional component or not.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows 10 have powershell.
XP didn't have it.
Powershell was added to windows from Windows 7

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There you go, I added a powershell detection in mariadb.bat

@MishimaHaruna MishimaHaruna added this to the Release v2019.06.02 milestone Jun 1, 2019
@MishimaHaruna MishimaHaruna merged commit f6505f6 into HerculesWS:master Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:documentation Affecting the documentation in the doc/ folder component:other Any issues that don't fall in the explicitly described components component:SQL Affecting the SQL databases type:enhancement Issue describes an enhancement or feature that should be implemented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants