Skip to content

Conversation

@bWolfie
Copy link
Contributor

@bWolfie bWolfie commented Oct 15, 2018

Pull Request Prelude

Changes Proposed

Adds 2 new script commands and 1 new atcommand.

  • resethate()
  • resetfeel()
  • @hatereset

We have the existing @feelreset command, and the functionality already exists for these commands so may as well make use of it.

Affected Branches:

  • master
  • stable

Issues addressed:

Known Issues and TODO List

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

src/map/script.c Outdated
BUILDIN_DEF(resetlvl,"i"),
BUILDIN_DEF(resetstatus,""),
BUILDIN_DEF(resetskill,""),
BUILDIN_DEF(resetfeel, "?"), // [Wolfie]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably better not add own signatures on simple lines?

@Emistry Emistry added component:core:scriptengine Affecting the script engine or the script commands component:documentation Affecting the documentation in the doc/ folder labels Oct 19, 2018
@Kenpachi2k13 Kenpachi2k13 added the codereview:accepted Code review was positive and the pull request can be accepted as is label Jan 11, 2020
@Kenpachi2k13 Kenpachi2k13 added this to the Release v2020.01.12 milestone Jan 11, 2020
@MishimaHaruna MishimaHaruna merged commit 5ee3fcc into HerculesWS:master Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codereview:accepted Code review was positive and the pull request can be accepted as is component:core:scriptengine Affecting the script engine or the script commands component:documentation Affecting the documentation in the doc/ folder

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants