Added countnameditem script command.

[kisuka]

Pull Request Prelude

• I have followed proper Hercules code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Adds a script command to return the number of signed items a character has in their inventory.

Currently you have to do the following for this same functionality:

.@slot3 = getcharid(0) & 65535;
.@slot4 = getcharid(0) >> 16;
countitem2(<item ID>, 1, 0, 0, 254, 0, .@slot3, .@slot4)

This pull request changes that so you can simply do this:

countnameditem(<item ID>, {<character id/name>});

[HerculesWSAPI]

This change is 

[Emistry]

could we have extra parameters for count named item of other specific char id that exists in player inventory too?
example: count how many named Apple that exists in PlayerA inventory are named PlayerB's Apple?

countnameditem(<item ID>, {<character id/name>, <target_char_id/name>});

use-case may not be wide, but seem useful if we could have it to count item that named using other player name in different player inventory.

[kisuka]

could we have extra parameters for count named item of other specific char id that exists in player inventory too?
example: count how many named Apple that exists in PlayerA inventory are named PlayerB's Apple?

countnameditem(<item ID>, {<character id/name>, <target_char_id/name>});

use-case may not be wide, but seem useful if we could have it to count item that named using other player name in different player inventory.

Sure. I'll need to tweak the code a bit but should be possible.

[kisuka]

Hmmm might be a bit more complex than I previously thought. So... even in the current state, the inscribed character has to be online for the count to be successful.

I'm not seeing any existing methods in script.c that allows the look up of offline character data. Should we possibly add a new function within pc.c that allows searching for a character's basic information even if they're offline? Or possibly a direct sql command within script.c on the function for countnameditem? Essentially we'd need to look up a character by either their name or id and use their char id within the slot 3 and 4 checks.

The other option is leaving it as self-named items only, which is how the aegis command works.

[4144]

If you want support for translations, you cant split sentenses.
Need use sprintf or other formatting functions.

Example: mes(sprintf(_$("You have %d apples with John's name on it!"), countnameditem(Apple, "John"))

But this is docs, because this i not sure is it really need here.

[dastgirp]

Or

Suggested change

	mes("You have "+countnameditem(Apple, "John")+" apples with John's name on it!");
	mesf("You have %d apples with John's name on it!", countnameditem(Apple, "John"));

[MishimaHaruna]

I agree that docs should show the recommended code style, since this is where people learn/copy from. The suggested mesf() variant is the cleanest/most appropriate

[MishimaHaruna]

I agree that docs should show the recommended code style, since this is where people learn/copy from. The suggested mesf() variant is the cleanest/most appropriate