Skip to content

Conversation

@4144
Copy link
Contributor

@4144 4144 commented Nov 15, 2018

Pull Request Prelude

  • I have followed [proper Hercules code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Add packet CA_ACK_MOBILE_OTP.
Add packet AC_REQ_MOBILE_OTP.
Add packet CA_OTP_CODE.
Add packet ZC_ENCHANT_EQUIPMENT.
Add script command enchantitem.
Add packet ZC_SERVICE_MESSAGE_COLOR.
Add script command servicemessage.
Fix packet ZC_PROPERTY_HOMUN.
Fix constant MAX_CHAR_BUF for all packet versions (fixes #2334)
Update packet ZC_AUTOSPELLLIST for main client.
Add packets CZ_START_USE_SKILL/CZ_STOP_USE_SKILL.
Update packet ZC_NPC_MARKET_OPEN.
Update packet CZ_PARTY_CONFIG and fix weight field.
Add packet CZ_CAMERA_INFO (command /viewpointvalue and /setcamera)
Add validation for function char_mmo_char_tobuf.
Add support for int32 (4 bytes) item id sizes in zero clients and main clients.
Add packets, script commands and scripts for inventory expansion.
Implement inventory expansion feature. http://imgc1.gnjoy.com/ufile/ro/2018/11/21/QK3O60RA1MGOMU301NUO.gif (partially can works in any clients)
Move packets structs in login server into separate files.
Update packets up to 2018-12-12.
Update messages up to 2018-12-12.
Update keys up to 2018-12-12.

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@4144 4144 changed the title Update packets up to 2018-11-14 Update packets up to 2018-11-21 Nov 21, 2018
@4144 4144 added this to the Release v2018.12.16 milestone Nov 21, 2018
@HerculesWSAPI
Copy link
Contributor

This pull request introduces 1 alert when merging b09886d into 97606ea - view on LGTM.com

new alerts:

  • 1 for Missing return statement

Comment posted by LGTM.com

@4144 4144 force-pushed the updatepackets branch 2 times, most recently from 71b2a61 to e7f2042 Compare November 27, 2018 02:46
@4144 4144 changed the title Update packets up to 2018-11-21 Update packets up to 2018-11-28 Nov 28, 2018
4144 added 5 commits December 15, 2018 21:05
This will allow use client command:
 /viewpointvalue - show/hide camera information
 /setcamera range rotation latitude - same with @camerainfo
@MishimaHaruna MishimaHaruna merged commit f1f1ef0 into HerculesWS:master Dec 16, 2018
@4144 4144 deleted the updatepackets branch December 17, 2018 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants