Skip to content

Conversation

@carloshenrq
Copy link
Contributor

Pull Request Prelude

Changes Proposed

There is a situation where you can invoke more than one sealed Baphomet.

To reproduce:

  1. Go to the second floor of catacombs and before you summon, as party leader, stop on the dialog "The bottom of the Main Altar trembles furiously.".
  2. Change party leader to another member, so, he can talk with the seal in the middle too. He stops on the same dialog "The bottom of the Main Altar trembles furiously."
  3. Keep doing it until all party is on the same dialog. All of them proceeds the dialog to invoke the sealed Baphomet, and we'll have a lot of sealed Baphomet unsealed.

So, this PR is to don't allow players to abuse the instance using this way.
I've just added instance status check and if the character is truly the party leader.

Issues addressed:
Related to instances #1582, not directly reported.

Only if already not summoned and player who are talking is the party leader.
@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@carloshenrq
Copy link
Contributor Author

@Asheraf or @4144 can you guys review it? Thank you =]

@Emistry Emistry added the component:scripts Affecting the scripts and NPCs label Dec 14, 2018
@dastgirp
Copy link
Member

Better yet, we should disable change party leader in instance maps, can anyone check official behaviour?

@Asheraf
Copy link
Contributor

Asheraf commented Dec 14, 2018

^ as dastgir said, changing party leader inside the instance should not be possible.

@carloshenrq
Copy link
Contributor Author

Block changing party leader doesn't fix the problem. If I'm allowed changing party leader in the instance... the problem persists. Anyway, do whatever you guys want.

@MishimaHaruna MishimaHaruna added this to the Release v2019.07.28 milestone Jul 28, 2019
@MishimaHaruna
Copy link
Member

Merging this, regardless of whether we're going to block changing party leaders - an additional sanity check in the script won't hurt.

@MishimaHaruna MishimaHaruna merged commit a6b4cc8 into HerculesWS:master Jul 28, 2019
@carloshenrq carloshenrq deleted the sealed_shrine_fix branch July 29, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:scripts Affecting the scripts and NPCs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants