Skip to content

Conversation

@darrensapalo
Copy link
Contributor

Pull Request Prelude

Changes Proposed

Fixed typo in db/item_db2.conf to fix Gungslinger into Gunslinger. Double checked in item_db.conf files to see if they used Gunslinger, which they did. The inline documentation simply had a typo.

Issues addressed:

No Github issue was created to deal with this typo.

`Gungslinger` should be `Gunslinger`.
@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@Emistry Emistry added the component:documentation Affecting the documentation in the doc/ folder label Dec 14, 2018
Star_Gladiator: true/false (boolean, defaults to false)
Soul_Linker: true/false (boolean, defaults to false)
Gungslinger: true/false (boolean, defaults to false)
Gunslinger: true/false (boolean, defaults to false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a space after true/false, so that the whitespace is consistent with all other lines

@MishimaHaruna MishimaHaruna added this to the Release v2018.12.16 milestone Dec 16, 2018
@MishimaHaruna MishimaHaruna merged commit 4231063 into HerculesWS:master Dec 16, 2018
@darrensapalo darrensapalo deleted the patch-1 branch December 16, 2018 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:documentation Affecting the documentation in the doc/ folder

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants