Implementation of LapineDdukDdak System #2336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This change is |
Asheraf
added
the
status:inprogress
Asheraf
force-pushed
the
lapineddukddak
branch
from
a54fd30 to
98a38e3
Compare
Contributor
|
This pull request introduces 1 alert when merging 98a38e3 into 406ae36 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
Asheraf
force-pushed
the
lapineddukddak
branch
from
98a38e3 to
5bff04d
Compare
Contributor
|
This pull request introduces 1 alert when merging 5bff04d into 406ae36 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
ghost
mentioned this pull request
hemagx
requested changes
Mar 4, 2019
Contributor
|
Also finally, please use enum for all client responses. |
Contributor
|
i hide some useless review comments, but some useless comments probably still left |
Asheraf
force-pushed
the
lapineddukddak
branch
3 times, most recently
from
5c4167a to
d6dd79b
Compare
4144
requested changes
May 24, 2019
Asheraf
force-pushed
the
lapineddukddak
branch
from
4ce6a46 to
a014752
Compare
Asheraf
removed
the
status:inprogress
4144
requested changes
Aug 24, 2019
Asheraf
force-pushed
the
lapineddukddak
branch
2 times, most recently
from
ff08b34 to
a2b9dfe
Compare
Emistry
reviewed
Aug 25, 2019
Asheraf
force-pushed
the
lapineddukddak
branch
4 times, most recently
from
7409b48 to
d1bf9ec
Compare
4144
approved these changes
Sep 22, 2019
MishimaHaruna
force-pushed
the
lapineddukddak
branch
from
d1bf9ec to
de6b3e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
TODO