Skip to content

Conversation

@AnnieRuru
Copy link
Contributor

Pull Request Prelude

Issues addressed

https://rathena.org/board/topic/117852-i-got-error-when-applying-custom-commands/?do=findComment&comment=356295
Fix a bug in custom disguise event script that causes the event to run indefinitely
the .RoundCount only increase when having players answer correctly
if nobody playing this event, or players give up before .Rounds(10) rounds, it will continue run forever

Changes Proposed

add the exact same line from answer correctly, into wrong answer label

Affected Branches

  • Master

Known Issues and TODO List

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@AnnieRuru AnnieRuru changed the base branch from stable to master January 13, 2019 11:58
@Emistry Emistry added the component:scripts Affecting the scripts and NPCs label Jan 13, 2019
Copy link
Contributor

@Asheraf Asheraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the changes to follow the Coding style , even if the whole file is still on old format, new code or changed one should be updated.

@AnnieRuru
Copy link
Contributor Author

AnnieRuru commented Jan 13, 2019

you know, if you say about fixing whole script syntax, I rather rewrite this whole thing
the way Euphy use initnpctimer for both counting down to start and during disguise are the same timer

the script should be read from top to bottom, not jump from label to label

Talking about custom scripts, can I upload my own custom scripts that was already in rathena repo ?
https://rathena.org/board/topic/89071-development-news/?do=findComment&comment=242965

- the .RoundCount only increase when having players answer correctly
if nobody playing this event, or players give up before .Rounds(10) rounds, it will continue run forever
Copy link
Contributor

@Asheraf Asheraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about adding new scripts to the custom folder, wasn't there a discussion that these should be moved into their own repo? perhaps we should just do it? and add the repo as a submodule?

@Asheraf Asheraf added this to the Release v2019.01.13 milestone Jan 13, 2019
@Asheraf Asheraf merged commit d546553 into HerculesWS:master Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:scripts Affecting the scripts and NPCs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants