Skip to content

Conversation

@sigtus
Copy link
Contributor

@sigtus sigtus commented Jan 29, 2019

Pull Request Prelude

Changes Proposed

Added missing return on F_GetTradeRestriction. The function only created a variable but didn't return its value.

Issues addressed: none

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@AnnieRuru
Copy link
Contributor

AnnieRuru commented Jan 29, 2019

not really your fault but, can you also remove all those curly brackets ?
https://github.com/HerculesWS/Hercules/wiki/Coding-Style#chapter-3-placing-braces-and-spaces

Do not unnecessarily use braces where a single statement will do.

	if (condition)
		action();

and

	if (condition)
		do_this();
	else
		do_that();

yup, tested working with

prontera,157,188,5	script	test gname2	1_F_MARIA,{
	dispbottom F_GetTradeRestriction(512);
	dispbottom F_GetTradeRestriction(12333);
	end;
}

@Emistry Emistry added the component:scripts Affecting the scripts and NPCs label Feb 26, 2019
@AnnieRuru AnnieRuru added the type:bug Issue is a bug or describes an incorrect behavior that should be fixed label Feb 28, 2019
@AnnieRuru AnnieRuru added this to the Release v2019.03.10 milestone Feb 28, 2019
@MishimaHaruna MishimaHaruna merged commit 63b87d3 into HerculesWS:master Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:scripts Affecting the scripts and NPCs type:bug Issue is a bug or describes an incorrect behavior that should be fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants