Skip to content

Add support for mysql versions where type my_bool not exists. #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MishimaHaruna merged 1 commit into from
Feb 11, 2019
Merged

Add support for mysql versions where type my_bool not exists. #2365

MishimaHaruna merged 1 commit into from
Feb 11, 2019

Conversation

@4144
Copy link
Contributor

@4144 4144 commented Feb 5, 2019

Pull Request Prelude

  • I have followed [proper Hercules code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Fixes #2363

@HerculesWSAPI
Copy link
Contributor

HerculesWSAPI commented Feb 5, 2019

This change is Reviewable

@4144 4144 mentioned this pull request Feb 5, 2019
Closed
@4144 4144 added this to the Release v2019.02.10 milestone Feb 11, 2019
@4144
Add support for mysql versions where type my_bool not exists.
9288a2b 
In new MySQL versions my_bool was replaced to bool.
@MishimaHaruna MishimaHaruna merged commit aca5362 into HerculesWS:master Feb 11, 2019
@4144 4144 deleted the mybool branch February 11, 2019 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MishimaHaruna MishimaHaruna MishimaHaruna approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Release v2019.02.10

Development

Successfully merging this pull request may close these issues.

3 participants

@4144 @HerculesWSAPI @MishimaHaruna