Skip to content

Different interfaces fixes #2378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MishimaHaruna merged 3 commits into from
Mar 11, 2019
Merged

Different interfaces fixes #2378

MishimaHaruna merged 3 commits into from
Mar 11, 2019

Conversation

@4144
Copy link
Contributor

@4144 4144 commented Feb 19, 2019 •
edited
Loading

Pull Request Prelude

  • I have followed [proper Hercules code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Add function connect_client into socket interface.
Move stylist_data into clif interface.

@HerculesWSAPI
Copy link
Contributor

HerculesWSAPI commented Feb 19, 2019

This change is Reviewable

@4144 4144 changed the title Add function connect_client into socket interface Different interfaces fixes Feb 19, 2019
@Asheraf Asheraf added this to the Release v2019.03.10 milestone Mar 2, 2019
@4144 4144 force-pushed the interfaces branch 2 times, most recently from e8b6efc to 6faa58e Compare March 7, 2019 20:09
@MishimaHaruna MishimaHaruna merged commit 23b515f into HerculesWS:master Mar 11, 2019
@4144 4144 deleted the interfaces branch March 11, 2019 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MishimaHaruna MishimaHaruna MishimaHaruna approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Release v2019.03.10

Development

Successfully merging this pull request may close these issues.

4 participants

@4144 @HerculesWSAPI @MishimaHaruna @Asheraf