setunitdata/getunitdata clean up. Phase 1 #2391
Merged
+118
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use *unitwarp for setunitdata - use *getmapxy for getunitdata
- this constant only used by *setunitdata, now has to use *unitwalk
Contributor
|
This change is |
4144
approved these changes
Feb 26, 2019
- once all the strings culprit are out, now only left with int to deal with. - Please make this script command only dealing with ONE INTEGER value
AnnieRuru
force-pushed
the
64-setunitdata_phase_1
branch
from
2b7e907 to
98ae816
Compare
3 tasks
AnnieRuru
added
type:bug
Emistry
added
the
component:documentation
dastgirp
approved these changes
Mar 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Issues addressed
I am so depress to see these 2 script commands broken in Hercules ...
NO KIDDING, 70% of them are broken ...
Changes Proposed
UDT_MAPIDXYconstantUDT_WALKTOXYconstant(int)in the documentationAffected Branches
Known Issues and TODO List
I made a FATAL mistakes for having 1 BIG Pull Request like this ->#2080
and having nobody review my work
so this time I'm breaking into MULTIPLE Pull Request and hopefully ... somebody will take notice
stable...AnnieRuru:34-setunitdata