Skip to content

Conversation

@AnnieRuru
Copy link
Contributor

@AnnieRuru AnnieRuru commented Feb 27, 2019

Pull Request Prelude

Issues addressed

Actually I was writing this for my custom scripts,
but when I do a search OnTouchNPC in npc folder, suddenly found this is actually official

rAthena already having *getattachedrid like for ages already
https://github.com/rathena/rathena/blob/master/doc/script_commands.txt#L922-L925

Changes Proposed

Add *mobattached and *killmonstergid script command

Tested with

prontera,155,185,5	script	qwer	1_F_MARIA,{
	getmapxy .@map$, .@x, .@y, UNITTYPE_NPC;
	.@mobid = monster( .@map$, .@x, .@y, "--ja--", PORING, 1, strnpcinfo(0)+"::Onaaa" );
	unitwalk .@mobid, 160,185;
	end;
Onaaa:
	npctalk "run";
	end;
}
prontera,160,185,5	script	asdf	1_F_MARIA,0,0,{
	end;
OnTouchNPC:
//	unitkill mobattached();
	killmonstergid mobattached();
//	unitemote mobattached(), e_gg;
	end;
}

Affected Branches

  • Master

Known Issues and TODO List

I accidentally push this branch into main hercules repo, need to remove it

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@AnnieRuru AnnieRuru added type:enhancement Issue describes an enhancement or feature that should be implemented status:code-review Awaiting code review component:core:scriptengine Affecting the script engine or the script commands labels Feb 28, 2019
@Emistry Emistry added the component:documentation Affecting the documentation in the doc/ folder label Feb 28, 2019
also fix quests_rachel, now support with *unitemote
@AnnieRuru AnnieRuru requested a review from Asheraf March 2, 2019 09:35
@Asheraf Asheraf added this to the Release v2019.03.10 milestone Mar 2, 2019
@AnnieRuru AnnieRuru added codereview:accepted Code review was positive and the pull request can be accepted as is and removed status:code-review Awaiting code review labels Mar 10, 2019
@MishimaHaruna MishimaHaruna merged commit e78a3b5 into HerculesWS:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codereview:accepted Code review was positive and the pull request can be accepted as is component:core:scriptengine Affecting the script engine or the script commands component:documentation Affecting the documentation in the doc/ folder type:enhancement Issue describes an enhancement or feature that should be implemented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants