Skip to content

Fix @bodystyle crash client #2402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MishimaHaruna merged 2 commits into from
Apr 7, 2019
Merged

Fix @bodystyle crash client #2402

MishimaHaruna merged 2 commits into from
Apr 7, 2019

Conversation

@AnnieRuru
Copy link
Contributor

@AnnieRuru AnnieRuru commented Mar 10, 2019

Pull Request Prelude

2 Issues addressed

  1. Job_Super_Novice_E is not supposed to be 3rd job #2383 (comment)
  2. if the player on 3rd job, having alternate bodystyle, and @jobchange into novice for example,will crash the client.
    This is extremely annoying when we testing stuffs

Changes Proposed

  1. Apply temporary fix so Job_Super_Novice_E no longer crash client
  2. Fix atcommand @jobchange when the player changing from 3rd job into non-3rd job, crashing client

Affected Branches

  • Master

Known Issues and TODO List

@HerculesWSAPI
Copy link
Contributor

HerculesWSAPI commented Mar 10, 2019

This change is Reviewable

@AnnieRuru AnnieRuru added type:bug Issue is a bug or describes an incorrect behavior that should be fixed component:core Affecting the Hercules core (i.e. not the game mechanics directly) status:code-review Awaiting code review labels Mar 10, 2019
@AnnieRuru
Fix atcommand "@jobchange" when the player changing from 3rd job
a9e2cd0 
having alternate body style into non-3rd job, crashing the client
@AnnieRuru AnnieRuru force-pushed the 71-bodystyle_crash branch from 05582a6 to a9e2cd0 Compare March 10, 2019 22:40
@HerculesWSAPI
Copy link
Contributor

HerculesWSAPI commented Mar 10, 2019

This pull request introduces 1 alert when merging a9e2cd0 into c9bab97 - view on LGTM.com

new alerts:

  • 1 for FIXME comment

Comment posted by LGTM.com

@MishimaHaruna MishimaHaruna added this to the Release v2019.04.07 milestone Apr 7, 2019
@MishimaHaruna MishimaHaruna merged commit f71e3a5 into HerculesWS:master Apr 7, 2019
@AnnieRuru AnnieRuru mentioned this pull request Dec 7, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MishimaHaruna MishimaHaruna MishimaHaruna approved these changes

Assignees

No one assigned

Labels

component:core Affecting the Hercules core (i.e. not the game mechanics directly) status:code-review Awaiting code review type:bug Issue is a bug or describes an incorrect behavior that should be fixed

Projects

None yet

Milestone

Release v2019.04.07

Development

Successfully merging this pull request may close these issues.

3 participants

@AnnieRuru @HerculesWSAPI @MishimaHaruna