Skip to content

Conversation

@AnnieRuru
Copy link
Contributor

Pull Request Prelude

Issues addressed

http://herc.ws/board/topic/16597-help-absorb-damage-taken-bonus/?do=findComment&comment=90812

Changes Proposed

change rand() into rnd()

Affected Branches

  • Master

Known Issues and TODO List

none

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@dastgirp dastgirp added this to the Release v2019.04.07 milestone Mar 14, 2019
@4144
Copy link
Contributor

4144 commented Mar 14, 2019

Warnings what present in forum topic mean missing some includes

not sure is really need use standard rand function or custom rnd.
Hercules by itself using only custon rnd

@AnnieRuru
Copy link
Contributor Author

use rnd() of course, search rnd() in our \src folder, all uses rnd(), not using rand()

only this sample plugin uses rand() which nobody bothers to load it

@MishimaHaruna MishimaHaruna merged commit 8986b65 into HerculesWS:master Apr 7, 2019
@AnnieRuru AnnieRuru deleted the 72-rand branch April 10, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants