Skip to content

Conversation

@AnnieRuru
Copy link
Contributor

Pull Request Prelude

Issues addressed

http://herc.ws/board/topic/16641-q-about-setunitdata/

Changes Proposed

Fix UDT_LEVEL when show_mob_info level display is on

Tested With

no.1 there is a battle_config.mobs_level_up,
when player is killed by a monster, it run clif->charnameack

Hercules/src/map/pc.c

Lines 8129 to 8143 in a0820df

if (battle_config.mobs_level_up && md->status.hp
&& md->level < pc->maxbaselv(sd)
&& !md->guardian_data && md->special_state.ai == AI_NONE// Guardians/summons should not level. [Skotlex]
) {
// monster level up [Valaris]
clif->misceffect(&md->bl,0);
md->level++;
status_calc_mob(md, SCO_NONE);
status_percent_heal(src,10,0);
if( battle_config.show_mob_info&4 )
{// update name with new level
clif->charnameack(0, &md->bl);
}
}

no.2

prontera,155,185,5	script	askdaksd	1_F_MARIA,{
	.@mobgid = monster( "this", -1,-1, "--ja--", PORING, 1 );
	setunitdata .@mobgid, UDT_MAXHP, 1000000;
	setunitdata .@mobgid, UDT_HP, 1000000;
	setunitdata .@mobgid, UDT_LEVEL, 99;
	end;
}

Affected Branches

  • Master

Known Issues and TODO List

yes I know there are a lot more,
but I am thinking its very much better to split into separate pull request now

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@AnnieRuru AnnieRuru added this to the Release v2019.04.07 milestone Mar 20, 2019
@MishimaHaruna MishimaHaruna merged commit 831d7cf into HerculesWS:master Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants