Fix an issue with named/brewed/forged items getting saved with the wrong character id #2425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This change is |
hemagx
force-pushed
the
hercules_signed_items_fix
branch
from
62c7eb6 to
b8719b9
Compare
hemagx
force-pushed
the
hercules_signed_items_fix
branch
from
b8719b9 to
e671d02
Compare
…ong character id
The isue was triggered by the refactoring of old undocumented code that
relied on the overflow behavior during assignment from int32 to int16
and from uint16 to int16, and by a subsequent clamping to SMALLINT range
operated by the SQL server.
Credits: Haru <[email protected]>
Fixes HerculesWS#2409
Signed-off-by: Ibrahim Zidan <[email protected]>
hemagx
force-pushed
the
hercules_signed_items_fix
branch
from
e671d02 to
9e934f3
Compare
4144
approved these changes
Apr 8, 2019
dastgirp
approved these changes
Apr 9, 2019
3 tasks
Contributor
|
what about |
MishimaHaruna
approved these changes
May 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Fix an issue with named/brewed/forged items getting saved with the wrong character id
The issue was triggered by the refactoring of old undocumented code that
relied on the overflow behavior during assignment from int32 to int16
and from uint16 to int16, and by a subsequent clamping to SMALLINT range
operated by the SQL server.
Issues addressed:
#2409