Skip to content

Conversation

@4144
Copy link
Contributor

@4144 4144 commented Apr 13, 2019

Pull Request Prelude

  • I have followed [proper Hercules code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Improve rodex attach handling.
Clean mail list on refresh rodex.

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@tlacson7
Copy link

tlacson7 commented Apr 14, 2019

I hope this fix rare instances of lost item to rodex. I did disable the mail system due to this problem.

  • player gets failed to attach then item is missing already. Cant duplicate the issue.

@4144
Copy link
Contributor Author

4144 commented Apr 14, 2019

@tlacson7 you sure on attach you can lost items?
probably it visually removed and if restart client, all items still in inventory? Can you explain steps how you get this issue?

@tlacson7
Copy link

@4144 i can't reproduce also the problem. It is lost even after closing client. I tra ed the uniqueid and it ends there -1 item on log. Cant find it anywhere in database. Its a rare case like 4 of them already.

@MishimaHaruna MishimaHaruna merged commit 0013040 into HerculesWS:master Apr 17, 2019
@4144 4144 deleted the rodexfixes branch April 19, 2019 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants