Added *consolemes script command #2440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emistry
added
type:enhancement
Contributor
|
This change is |
4144
approved these changes
Apr 14, 2019
Contributor
|
nice. will mean lots of updates for custom script is needed, but much better! |
dastgirp
approved these changes
Apr 21, 2019
hemagx
requested changes
Apr 28, 2019
npc/custom/etc/quest_warper.txt
Outdated
| warp $QW_SP_WarpMap$, $QW_SP_WarpX, $QW_SP_WarpY; | ||
| close2; | ||
| debugmes "Please check your special warp menu settings on the Warpra."; | ||
| consolemes(CONSOLEMES_INFO, "Please check your special warp menu settings on the Warpra."); |
Contributor
There was a problem hiding this comment.
I think this should be a warning too
src/map/script.c
Outdated
| ShowDebug("consolemes: %s\n", StrBuf->Value(&buf)); | ||
| break; | ||
| case CONSOLEMES_ERROR: | ||
| ShowError("consolemes: (st->rid:%d) (st->oid:%d) %s\n", st->rid, st->oid, StrBuf->Value(&buf)); |
Contributor
There was a problem hiding this comment.
Can you please put a space after :, eg (st->oid: %d)
src/map/script.c
Outdated
| ShowError("consolemes: (st->rid:%d) (st->oid:%d) %s\n", st->rid, st->oid, StrBuf->Value(&buf)); | ||
| break; | ||
| case CONSOLEMES_WARNING: | ||
| ShowWarning("consolemes: (st->rid:%d) (st->oid:%d) %s\n", st->rid, st->oid, StrBuf->Value(&buf)); |
Contributor
There was a problem hiding this comment.
Can you please put a space after :, eg (st->oid: %d)
Contributor
|
Also please change your target branch to master, it's impossible to merge right now as it's target stable branch. |
- deprecated `*debugmes` script command. - added `*consolemes` script command which display the console message based on `type`. - allow map-server console to auto logging into text file depend on type of message.
Emistry
force-pushed
the
scriptcommand_consolemes
branch
from
212c762 to
9f6ffd2
Compare
hemagx
approved these changes
Apr 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
*debugmesscript command.*consolemesscript command which display the console message based ontype.Currently, the
st->ridandst->oidvalues, i keep it in bothShowWarning()andShowError(). Should we still remain it inShowDebug()? any advice?Issues addressed:
debugmeshas hardcoded stringscript debug ....seem unnecessary most of the time, and tend to ignored it.Sometime we use
debugmesto display info, which aren't really "debugging" just purely for information display, so its more appropriate to use other likeShowInfo,ShowStatusetc.Preview :
Details