Skip to content

Conversation

@Emistry
Copy link
Member

@Emistry Emistry commented Apr 14, 2019

Pull Request Prelude

Changes Proposed

  • doesn't allow chatroom creation/switch if the coordinated cell are set with cell_nochat.
  • chatroom will be auto deleted.
Details
-	script	sample	-1,{

	OnInit:
		.@map$ = "prontera";
		
		.@max_x = getmapinfo(MAPINFO_SIZE_X, .@map$);
		.@max_y = getmapinfo(MAPINFO_SIZE_Y, .@map$);
		setcell(.@map$, 0, 0, .@max_x, .@max_y, cell_nochat, true);
		
		.@range = 10;
		.@center_x = 155;
		.@center_y = 181;
		setcell(.@map$, (.@center_x - .@range), (.@center_y - .@range), (.@center_x + .@range), (.@center_y + .@range), cell_nochat, false);
		end;
}

player 1 - create a normal chatroom at normal cells that dont have cell_nochat.
player 2 - move to cell_nochat area, and join the chatroom
player 1 - leave the chatroom
** at this point, chatroom shall be auto deleted since the new owner are located in the cell_nochat area.

Issues addressed:
#1569

- doesn't allow chatroom creation/switch if the coordinated cell are set
with cell_chknochat.
- chatroom will be auto deleted.
@Emistry Emistry added the component:core Affecting the Hercules core (i.e. not the game mechanics directly) label Apr 14, 2019
@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@Emistry Emistry changed the base branch from stable to master April 14, 2019 14:07
@bWolfie
Copy link
Contributor

bWolfie commented Apr 15, 2019

Nice one! Much better solution than what I was using where player on nochat cell just can't join the chat.

@hemagx hemagx merged commit a99d988 into HerculesWS:master Apr 29, 2019
@MishimaHaruna MishimaHaruna added this to the Release v2019.05.05 milestone May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:core Affecting the Hercules core (i.e. not the game mechanics directly)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants