Skip to content

Update MSVC version naming in console info #2450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hemagx merged 1 commit into from
Apr 28, 2019
Merged

Update MSVC version naming in console info #2450

hemagx merged 1 commit into from
Apr 28, 2019

Conversation

@Asheraf
Copy link
Contributor

@Asheraf Asheraf commented Apr 21, 2019

Pull Request Prelude

Changes Proposed

properly print the names for visual studio 2017 and 19

@HerculesWSAPI
Copy link
Contributor

HerculesWSAPI commented Apr 21, 2019

This change is Reviewable

@Asheraf Asheraf added this to the Release v2019.05.05 milestone Apr 21, 2019
@hemagx hemagx merged commit 0505a99 into HerculesWS:master Apr 28, 2019
@Asheraf Asheraf deleted the msvcversionname branch June 2, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@4144 4144 4144 approved these changes

@hemagx hemagx hemagx approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Release v2019.05.05

Development

Successfully merging this pull request may close these issues.

4 participants

@Asheraf @HerculesWSAPI @4144 @hemagx