Dehardcode Rental Expire/Renting item checks #2462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This change is |
Contributor
|
what will happened if other script already running and rental script will be run? |
dastgirp
requested changes
May 10, 2019
Contributor
Author
|
@4144 |
hemagx
force-pushed
the
dehardcoded_rentrals
branch
from
450104b to
d35f03e
Compare
Contributor
|
i mean if you do attach to player, it will terminate previous script. but i not sure is you attaching script to player or run in deattached |
Contributor
Author
|
@4144 Item scripts works in attached mode, yet it can still be used while talking/executing NPC perfectly fine. |
…nges - OnRentalStartScript triggered when a rental item is added to inventory - OnRentalEndScript triggered when a rental period end/expire of the item Related HerculesWS#140 Signed-off-by: Ibrahim Zidan <[email protected]>
…font Signed-off-by: Ibrahim Zidan <[email protected]>
…ript field in item database for those items instead Fixes HerculesWS#140 Signed-off-by: Ibrahim Zidan <[email protected]>
Signed-off-by: Ibrahim Zidan <[email protected]>
hemagx
force-pushed
the
dehardcoded_rentrals
branch
from
d35f03e to
ad19056
Compare
MishimaHaruna
approved these changes
Sep 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Implemented new script fields in item db executes when item is rented and when item rent expires
Implemented a new script command getfont() gets the current player font id
Fixed hardcoded checks for rental items in source
Issues addressed:
#140