Add new atcommand *reloadnpc #2476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This change is |
Emistry
added
component:core
4144
requested changes
May 17, 2019
src/map/atcommand.c
Outdated
|
|
||
| FILE *fp; | ||
| // check if script file exists | ||
| if ((fp = fopen(message, "r")) == NULL) { |
Contributor
There was a problem hiding this comment.
code fp = fopen(message, "r") can be moved into line with FILE *fp as FILE *fp = fopen(message, "r")
- `@reloadnpc <path>` - unloads all NPCs in a file and reload it again. - Be aware that mapflags and monster spawned directly are not removed.
Emistry
force-pushed
the
atcommand_reloadnpc
branch
from
da788c0 to
f909e40
Compare
4144
approved these changes
May 18, 2019
Contributor
|
This probably could be merged with @unloadnpcfile and @loadnpcfile maybe? something like.. @npcfile load npc/lols/fasdfas.txt or @npcfile 1 npc/lols/fasdfas.txt prob a single command with arguments, I dont think this command is used on anything so we should be allowed to change them maybe with constants or maybe just @file making it possible to do more things with it? idk why 3 commands but i guess thats how things are? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
@reloadnpc <path>- unloads all NPCs in a file and reload it again.Issues addressed:
none