Split HULD translations to per NPC file instead of one large file #2492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This change is |
dastgirp
changed the title
Contributor
|
Those are all the fixes that we mentioned before. It is working for me |
4144
requested changes
Jun 8, 2019
Contributor
4144
left a comment
4144
left a comment
There was a problem hiding this comment.
Missing nullpo checks in different functions
and last fix commits need squash with something else.
Cyanide0210
approved these changes
Jun 16, 2019
Contributor
Cyanide0210
left a comment
Cyanide0210
left a comment
There was a problem hiding this comment.
Im not an expert in code, but seems to be working just fine
Signed-off-by: Haru <[email protected]>
Signed-off-by: Haru <[email protected]>
Member
Author
|
@4144 Fixed and rebased |
4144
approved these changes
Oct 2, 2019
MishimaHaruna
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Modified Haru's PR whose aim was to split HULD Translation files.
Fixed minor changes in this PR which resulted in failure to read translation files.
Issues addressed: