Skip to content

Conversation

@Emistry
Copy link
Member

@Emistry Emistry commented Jul 11, 2019

Pull Request Prelude

Changes Proposed

  • failsafe function to not execute the query
  • avoid EXP sharing bug

This adds a failsafe function to not execute the query during the family check AND avoid an exp sharing bug when the child_id is == 0 AND the returning value from the SQL is 0 also, this makes the check on char_child function returns a FALSE 1(positive)

Issues addressed:
rathena/rathena#3350

- failsafe function to not execute the query
- avoid EXP sharing bug
@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@Emistry Emistry added this to the Upstream merges milestone Jul 11, 2019
@Emistry Emistry added the component:core Affecting the Hercules core (i.e. not the game mechanics directly) label Jul 11, 2019
@MishimaHaruna MishimaHaruna merged commit 754f7fe into HerculesWS:master Jul 28, 2019
@Emistry Emistry deleted the family_failsafe_check branch July 29, 2019 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:core Affecting the Hercules core (i.e. not the game mechanics directly)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants