Skip to content

Update Homunculus obtain EXP from master #2507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MishimaHaruna merged 1 commit into from
Jul 28, 2019
Merged

Update Homunculus obtain EXP from master #2507

MishimaHaruna merged 1 commit into from
Jul 28, 2019

Conversation

@Emistry
Copy link
Member

@Emistry Emistry commented Jul 20, 2019

Pull Request Prelude

Changes Proposed

  • homunculus will obtain a portion or full EXP (1~100%) from master. (0% = disable)
  • @showexp shall display homunculus EXP gain.

homunculus gain 10% bonus exp from master. (default = 10%)

Battle configuration has been reloaded.
Experience Gained Base:56 (0.00%) Job:60 (0.06%)
Homunculus Experience Gained Base:5 (0.23%)
Details

homunculus gain 50% bonus exp from master.

Battle configuration has been reloaded.
Experience Gained Base:56 (0.00%) Job:60 (0.06%)
Homunculus Experience Gained Base:28 (1.29%)

homunculus gain 100% bonus exp from master.

Gained exp is now shown.
Experience Gained Base:56 (0.00%) Job:60 (0.06%)
Homunculus Experience Gained Base:56 (2.57%)

Issues addressed:
#2313

@Emistry Emistry added the component:core Affecting the Hercules core (i.e. not the game mechanics directly) label Jul 20, 2019
@Emistry Emistry added this to the Match Official Content milestone Jul 20, 2019
@HerculesWSAPI
Copy link
Contributor

HerculesWSAPI commented Jul 20, 2019

This change is Reviewable

4144
4144 requested changes Jul 20, 2019
View reviewed changes
src/map/homunculus.c

if (hd->master->state.showexp) {
char output[256];
sprintf(output, "Homunculus Experience Gained Base:%u (%.2f%%)", exp, ((float)exp / (float)hd->exp_next * (float)100));
Copy link
Contributor

@4144 4144 Jul 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need check hd->exp_next for closer to 0 for avoid division by zero

Copy link
Member Author

@Emistry Emistry Jul 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@Emistry @MishimaHaruna
Update Homunculus obtain EXP from master
5ac507e 
- homunculus will obtain a portion or full EXP from master.
- fixes HerculesWS#2313
@MishimaHaruna MishimaHaruna merged commit cd04fd9 into HerculesWS:master Jul 28, 2019
@Emistry Emistry deleted the homun_exp branch July 29, 2019 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@4144 4144 4144 approved these changes

@MishimaHaruna MishimaHaruna MishimaHaruna approved these changes

Assignees

No one assigned

Labels

component:core Affecting the Hercules core (i.e. not the game mechanics directly)

Projects

None yet

Milestone

Release v2019.07.28

Development

Successfully merging this pull request may close these issues.

4 participants

@Emistry @HerculesWSAPI @4144 @MishimaHaruna