Skip to content

Conversation

@Emistry
Copy link
Member

@Emistry Emistry commented Jul 29, 2019

Pull Request Prelude

Changes Proposed

  • show file path

Current result: (display only file name without extension and path)

[Status]: Done reading '416' entries in 'item_combo_db'.

Updated result: (display file path + name)

[Status]: Done reading '416' entries in 'db/re/item_combo_db'.
Details
[Status]: Done reading '64' command aliases in 'conf/atcommand.conf'.
[Status]: Done reading '4' channels in 'conf/channels.conf'.
[Status]: Done reading '10606' entries in 'db/re/item_db.conf'.
[Status]: Done reading '263' entries in 'db/re/item_db2.conf'.
[Status]: Done reading '186' entries in 'db/item_options.conf'.
[Status]: Done reading '416' entries in 'db/re/item_combo_db'.
[Status]: Done reading '57' entries in 'db/re/item_group.conf'.
[Status]: Done reading '4' entries in 'db/re/item_chain.conf'.
[Status]: Done reading '270' entries in 'db/re/item_packages.conf'.
[Status]: Done reading '16' entries in 'db/cashshop_db.conf'.
[Status]: Done reading '21' entries in 'db/attendance_db.conf'.
[Status]: Done reading '4' valid clans of '4' entries in 'conf/clans.conf'.
[Status]: Done reading '1124' entries in 'db/re/skill_db.conf'.
[Status]: Done reading '264' entries in 'db/produce_db.txt'.
[Status]: Done reading '136' entries in 'db/create_arrow_db.txt'.
[Status]: Done reading '205' entries in 'db/abra_db.txt'.
[Status]: Done reading '17' entries in 'db/spellbook_db.txt'.
[Status]: Done reading '23' entries in 'db/magicmushroom_db.txt'.
[Status]: Done reading '16' entries in 'db/skill_improvise_db.txt'.
[Status]: Done reading '74' entries in 'db/skill_changematerial_db.txt'.
[Status]: Done reading '16' zones in 'db/re/map_zone_db.conf'.
[Status]: Done reading '0' entries in 'db/mob_item_ratio.txt'.
[Status]: Done reading '0' entries in 'db/option_drop_groups.conf'.
[Status]: Done reading '40' entries in 'db/mob_chat_db.txt'.
[Status]: Done reading '1724' entries in 'db/re/mob_db.conf'.
[Status]: Done reading '370' entries in 'db/re/mob_db2.conf'.
[Status]: Done reading '1236' entries in 'db/re/mob_skill_db.conf'.
[Status]: Done reading '1' entries in 'db/mob_skill_db2.conf'.
[Status]: Done reading '0' entries in 'db/mob_avail.txt'.
[Status]: Done reading '480' entries in 'db/re/mob_branch.txt'.
[Status]: Done reading '14' entries in 'db/re/mob_poring.txt'.
[Status]: Done reading '47' entries in 'db/re/mob_boss.txt'.
[Status]: Done reading '331' entries in 'db/mob_pouch.txt'.
[Status]: Done reading '25' entries in 'db/mob_classchange.txt'.
[Status]: Done reading '8' entries in 'db/re/mob_race2_db.txt'.
[Status]: Done reading '18' entries in 'db/re/exp_group_db.conf'.
[Status]: Done reading '35' entries in 'db/re/level_penalty.txt'.
[Status]: Done reading '4' entries in 'db/re/attr_fix.txt'.
[Status]: Done reading '175' entries in 'db/re/statpoint.txt'.
[Status]: Done reading '9' groups in 'conf/groups.conf'.
[Status]: Done reading '5' entries in 'db/re/refine_db.conf'.
[Status]: Done reading '134' entries in 'db/job_db2.txt'.
[Status]: Done reading '3' entries in 'db/re/size_fix.txt'.
[Status]: Done reading '394' entries in 'db/sc_config.txt'.
[Status]: Done reading '116' entries in 'db/re/job_db.conf'.
[Status]: Done reading '35' entries in 'db/castle_db.conf'.
[Status]: Done reading '15' entries in 'db/guild_skill_tree.txt'.
[Status]: Done reading '80' entries in 'db/re/pet_db.conf'.
[Status]: Done reading '0' entries in 'db/pet_db2.conf'.
[Status]: Done reading '107' entries in 'db/re/homunculus_db.txt'.
[Status]: Done reading '150' levels in 'db/re/exp_homun.txt'.
[Status]: Done reading '82' entries in 'db/homun_skill_tree.txt'.
[Status]: Done reading '61' entries in 'db/mercenary_db.txt'.
[Status]: Done reading '157' entries in 'db/mercenary_skill_db.txt'.
[Status]: Done reading '12' elementals in 'db/elemental_db.txt'.
[Status]: Done reading '36' entries in 'db/elemental_skill_db.txt'.
[Status]: Done reading '3095' entries in 'db/quest_db.conf'.
[Status]: Done reading '342' entries in 'db/re/achievement_db.conf'.
[Status]: Done reading '11' entries in 'db/achievement_rank_db.conf'.

Issues addressed:
missing file path info in console.

@Emistry Emistry added the type:enhancement Issue describes an enhancement or feature that should be implemented label Jul 29, 2019
@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@Emistry Emistry force-pushed the itemdb_read_combos branch from 3456c34 to 1feeb9d Compare July 30, 2019 15:43
@Emistry Emistry changed the title Fix missing item_combo_db file path in console. Fix missing file path in console. Jul 30, 2019
@MishimaHaruna MishimaHaruna added this to the Release v2019.08.25 milestone Aug 25, 2019
@MishimaHaruna MishimaHaruna merged commit ad7ebbe into HerculesWS:master Aug 25, 2019
@Emistry Emistry deleted the itemdb_read_combos branch August 26, 2019 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:enhancement Issue describes an enhancement or feature that should be implemented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants