Update Siegfried Tokens support. #2515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emistry
added
type:bug
Contributor
|
This change is |
4144
approved these changes
Jul 30, 2019
Contributor
|
Can't this just be an item_chain group and iterate though it so it can be reused for other items (Emperium G for instance). |
Contributor
|
normally need dehardcode all item ids. but this probably bit complex. but yes may be it time to start at least for some items? |
Emistry
force-pushed
the
pc_have_siegfried_token
branch
from
24d3100 to
7063a65
Compare
Member
Author
|
I have updated it using the item_chain, but the rate part, i just leave a dummy rate since its not used anywhere. |
Emistry
force-pushed
the
pc_have_siegfried_token
branch
4 times, most recently
from
fd85783 to
932e987
Compare
Asheraf
approved these changes
Aug 10, 2019
MishimaHaruna
approved these changes
Aug 25, 2019
- allow player to revive if inventory consists of any type of siegfried tokens listed in the `ITMCHAIN_SIEGFRIED`.
Emistry
force-pushed
the
pc_have_siegfried_token
branch
from
932e987 to
d3205c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Hercules/db/re/item_chain.conf
Lines 62 to 66 in 7063a65
Issues addressed:
Currently, if players has any of these siegfried token, only
7621can be used to revive the players, the rest of the siegfried tokens will only enable the client to show the resurrection button but doesn't revive the players if clicked.Known Issue:
I have no idea in what order of these tokens are consumed in official server. If the players have multiple different tokens, which shall be consumed first?
If anyone know, kindly let me know, so that I could update it.