Name partial match #2523
Merged
Name partial match #2523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This change is |
MishimaHaruna
force-pushed
the
name-partial-match
branch
from
19a82cc to
312b644
Compare
4144
reviewed
Aug 26, 2019
…bled. Partial match is now disabled in all the internal (source) and script lookups, while it's enabled for the lookups requested by atcommands and client. Signed-off-by: Haru <[email protected]>
Signed-off-by: Haru <[email protected]>
Signed-off-by: Haru <[email protected]>
MishimaHaruna
force-pushed
the
name-partial-match
branch
from
312b644 to
20a1f4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
When the
partial_name_scansetting is enabled, it currently affects various name lookups done in source and script, even where it is not safe to do so and a complete match would be necessary.This PR limits the partial match to atcommands and player/client commands, where it's safe to do so.