Skip to content

Conversation

@MishimaHaruna
Copy link
Member

Pull Request Prelude

Changes Proposed

This PR contains a few different fixes related to homunculi.

  1. Auto-vaporize fix: the automatic homunculus vaporization (on death or character skill reset) can fail if the homunculus has less than 80% HP. This fix forces it to occur if any other condition would prevent it. Manual uses of the Vaporize skill are still affected by the 80% HP restriction.
  2. HP/SP refill on login: the HP and SP of homunculi are currently refilled on login. This was caused by code shared between homunculus creation and login. The fix prevents them to refill on login.
  3. Intimacy requirement fix: the intimacy requirements for the homunculi's ultimate skills weren't read correctly from the database. They're now interpreted as documented.
  4. Standalone homunculus/pet fix: homunculi, pets, mercenaries, etc. are no longer loaded if the character is logged in without a client attached (such as when autotrading).

Arguably, (1) can be considered a feature rather than a bug (depending on how closely one wants to emulate the bugs of official servers). I will not provide a configuration toggle for it, since I have no interest in emulating official bugs in Hercules, but if anyone is interested, feel free to add commits to this pull request (or open a pull request against my branch, before this is merged)

Issues addressed: Point (1) is related to #1130.

MishimaHaruna and others added 6 commits August 26, 2019 01:22
… reset

The >80% HP condition is now ignored in the cases the vaporization is
forced by the server

Signed-off-by: Haru <[email protected]>
Signed-off-by: Haru <[email protected]>
They're now only refilled on homunculus creation

Signed-off-by: Haru <[email protected]>
Signed-off-by: Haru <[email protected]>
…'t have a client attached to it (e.g. is autotrading).

Signed-off-by: Haru <[email protected]>
@MishimaHaruna MishimaHaruna added this to the Release v2019.09.22 milestone Aug 25, 2019
@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@MishimaHaruna MishimaHaruna merged commit 76896e8 into HerculesWS:master Sep 22, 2019
@MishimaHaruna MishimaHaruna deleted the homunculus-fixes branch September 22, 2019 18:02
@doobiegaming
Copy link

@MishimaHaruna have you fix homunculus on song? anyways im fron rathena. hahaha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants