-
Notifications
You must be signed in to change notification settings - Fork 772
Convert sc_config to use libconfig #2526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5073709 to
ce07ce1
Compare
Emistry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might as well consider to include enhancement for this too?
Lines 12414 to 12423 in ce07ce1
| /* status that can't be individually removed (TODO sc_config option?) */ | |
| switch (type) { | |
| case SC_WEIGHTOVER50: | |
| case SC_WEIGHTOVER90: | |
| case SC_NOCHAT: | |
| case SC_PUSH_CART: | |
| return true; | |
| default: | |
| break; | |
| } |
I think he should keep it this way for now, if we add this it will break the convertor and people will have to do a lot more to ensure their sc_config.txt is converted correctly, perhaps this shall be done in later PR, i will merge this PR as soon as it's approved to master and move as much hardcoded values to the new sc_config.conf |
5d16822 to
e30a5f9
Compare
|
Do you think about adding official options that are missing ?
|
in future all hard-coded settings shall be moved, for now to make it simple and easy on people to migrate we're sticking to a simple conversion without adding feautres |
e30a5f9 to
6ea8e59
Compare
4e2ac68 to
6ea8e59
Compare
Pull Request Prelude
Changes Proposed
just simple conversion because the old format makes me sad..
Issues addressed: