Skip to content

Conversation

@Asheraf
Copy link
Contributor

@Asheraf Asheraf commented Aug 26, 2019

Pull Request Prelude

Changes Proposed

just simple conversion because the old format makes me sad..

Issues addressed:

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@Asheraf Asheraf force-pushed the statusconfiglibconf branch from 5073709 to ce07ce1 Compare August 26, 2019 14:26
Copy link
Member

@Emistry Emistry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well consider to include enhancement for this too?

Hercules/src/map/script.c

Lines 12414 to 12423 in ce07ce1

/* status that can't be individually removed (TODO sc_config option?) */
switch (type) {
case SC_WEIGHTOVER50:
case SC_WEIGHTOVER90:
case SC_NOCHAT:
case SC_PUSH_CART:
return true;
default:
break;
}

@hemagx
Copy link
Contributor

hemagx commented Aug 26, 2019

Might as well consider to include enhancement for this too?

Hercules/src/map/script.c

Lines 12414 to 12423 in ce07ce1

/* status that can't be individually removed (TODO sc_config option?) */
switch (type) {
case SC_WEIGHTOVER50:
case SC_WEIGHTOVER90:
case SC_NOCHAT:
case SC_PUSH_CART:
return true;
default:
break;
}

I think he should keep it this way for now, if we add this it will break the convertor and people will have to do a lot more to ensure their sc_config.txt is converted correctly, perhaps this shall be done in later PR, i will merge this PR as soon as it's approved to master and move as much hardcoded values to the new sc_config.conf

@Asheraf Asheraf force-pushed the statusconfiglibconf branch 4 times, most recently from 5d16822 to e30a5f9 Compare August 28, 2019 00:10
@marcosbucarte
Copy link

Do you think about adding official options that are missing ?

  • Send
  • IgnorePretendDead
  • ActorAppearance
  • SendMultiCast
  • ["backward compatibility send"]

@hemagx
Copy link
Contributor

hemagx commented Aug 28, 2019

Do you think about adding official options that are missing ?

* **Send**

* **IgnorePretendDead**

* **ActorAppearance**

* **SendMultiCast**

* **["backward compatibility send"]**

in future all hard-coded settings shall be moved, for now to make it simple and easy on people to migrate we're sticking to a simple conversion without adding feautres

@Asheraf Asheraf force-pushed the statusconfiglibconf branch from e30a5f9 to 6ea8e59 Compare August 28, 2019 01:08
@Asheraf Asheraf force-pushed the statusconfiglibconf branch 2 times, most recently from 4e2ac68 to 6ea8e59 Compare August 28, 2019 14:26
@hemagx hemagx merged commit 6dbabae into HerculesWS:master Sep 10, 2019
@Asheraf Asheraf deleted the statusconfiglibconf branch June 2, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants