Fixed several issues in itemdb_search_name function #2535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrote item name checks in both functions to be more readable Changed flag to be enum item_name_search_flag and made itemdb_searchname_array_sub respect flag given to parent function Corrected item count returned by parent function when dbmap search is performed Fixed a memory violation caused by the old code when dbmap search is performed Fixed dbmap searching having static array size which did not adhire to the size passed to the function Signed-off-by: Ibrahim Zidan <[email protected]>
Contributor
|
This change is |
4144
approved these changes
Sep 19, 2019
Signed-off-by: Ibrahim Zidan <[email protected]>
hemagx
force-pushed
the
itemdb_violation
branch
from
615263f to
3be1dd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Rewrote item name checks in both functions to be more readable
Changed flag to be enum item_name_search_flag and made itemdb_searchname_array_sub respect flag given to parent function
Corrected item count returned by parent function when dbmap search is performed
Fixed a memory violation caused by the old code when dbmap search is performed
Fixed dbmap searching having static array size which did not adhire to the size passed to the function
Issues addressed: