Skip to content

Compile fixes #2536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MishimaHaruna merged 5 commits into from
Sep 23, 2019
Merged

Compile fixes #2536

MishimaHaruna merged 5 commits into from
Sep 23, 2019

Conversation

@MishimaHaruna
Copy link
Member

@MishimaHaruna MishimaHaruna commented Sep 22, 2019

Pull Request Prelude

Changes Proposed

  • The code isn't currently compatible with the -Warray-bounds check of gcc-9, so it's now disabled by default (it complains about the ZEROED_BLOCK implementation)
  • The HPM code used a pointer to pointer to void where it needed a pointer to pointer to function. It's now replaced with a typedef, to stop static analyzers and linters from complaining about it.
  • The (commented out) custom code for the Venom Splasher countdown suffered severe bit-rot and it was no longer compilable. It is now updated.
  • Debian 10 (buster) is now stable. The gitlab-ci builds have been updated to reflect that (and to fix the related build failures). This makes gcc-8 the default compiler for the jobs where previously gcc-6 was used.

Issues addressed: N/A

@MishimaHaruna
Disable some warnings when compiling with gcc-9
092e320 
The warning flag -Warray-bounds is currently not compatible with the ZEROED_BLOCK implementation

Signed-off-by: Haru <[email protected]>
@MishimaHaruna
Fix an assignment of a function pointer to a non-function pointer
a4c438d 
Signed-off-by: Haru <[email protected]>
@MishimaHaruna
Fix the (disabled by default) custom Venom Splasher countdown timer code
f3e46d6 
Signed-off-by: Haru <[email protected]>
@MishimaHaruna
Mark some forgotten symbols as static
48a506f 
Signed-off-by: Haru <[email protected]>
@MishimaHaruna
Update the gitlab-ci builds
7ff0e07 
- Changed the i386, gcov and asan build from gcc-6 to gcc-8 as available
  in buster (now stable)
- Moved clang-3.9, clang-5.0 and gcc-4.8 to the secondary stage
- Moved clang-4.0, clang-7 and gcc-8 to the primary stage
- Added clang-8
- Added mariadb-10.3
- Updated debian image tags to represent more accurately package
  availability

Signed-off-by: Haru <[email protected]>
@MishimaHaruna MishimaHaruna added this to the Release v2019.09.22 milestone Sep 22, 2019
@HerculesWSAPI
Copy link
Contributor

HerculesWSAPI commented Sep 22, 2019

This change is Reviewable

@MishimaHaruna MishimaHaruna merged commit 418b26d into HerculesWS:master Sep 23, 2019
@MishimaHaruna MishimaHaruna deleted the compile-fixes branch September 23, 2019 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Release v2019.09.22

Development

Successfully merging this pull request may close these issues.

2 participants

@MishimaHaruna @HerculesWSAPI