Skip to content

Update NPC locations #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MishimaHaruna merged 4 commits into from
Nov 17, 2019
Merged

Update NPC locations #2542

MishimaHaruna merged 4 commits into from
Nov 17, 2019

Conversation

@Emistry
Copy link
Member

@Emistry Emistry commented Oct 2, 2019

Pull Request Prelude

Changes Proposed

Update NPC locations

Issues addressed:
Merge from rAthena
rathena/rathena@752d314
rathena/rathena@0d1eb99
rathena/rathena@ce42168

Credits: https://github.com/JohnnyPlayy

@Emistry Emistry added component:scripts Affecting the scripts and NPCs mode:renewal For strictly Renewal issues mode:pre-renewal For strictly Pre-Renewal issues labels Oct 2, 2019
@HerculesWSAPI
Copy link
Contributor

HerculesWSAPI commented Oct 2, 2019

This change is Reviewable

@JohnnyPlayy
Copy link

JohnnyPlayy commented Oct 7, 2019

There are still some portals missing

Yuno

yuno,195,87,0	warp	yunStyle00	1,1,yuno_in04,186,28
yuno_in04,192,28,0	warp	yunStyle01	1,1,yuno,198,87

Lighthalzen

lighthalzen,340,240,0	warp	lhz_pub3-1	1,1,lhz_in03,180,86
lhz_in03,180,90,0	warp	lhz_pub3-2	1,1,lighthalzen,339,245

@MishimaHaruna MishimaHaruna added this to the Release v2019.10.20 milestone Oct 18, 2019
@MishimaHaruna
Copy link
Member

MishimaHaruna commented Oct 18, 2019

Pinging @Emistry wrt @JohnnyPlayy 's message (this PR is scheduled for merging in this weekend's release)

@MishimaHaruna MishimaHaruna merged commit 16f3d5e into HerculesWS:master Nov 17, 2019
@Emistry Emistry deleted the npc_locations branch November 17, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dastgirp dastgirp dastgirp approved these changes

@MishimaHaruna MishimaHaruna MishimaHaruna approved these changes

Assignees

No one assigned

Labels

component:scripts Affecting the scripts and NPCs mode:pre-renewal For strictly Pre-Renewal issues mode:renewal For strictly Renewal issues

Projects

None yet

Milestone

Release v2019.11.17

Development

Successfully merging this pull request may close these issues.

5 participants

@Emistry @HerculesWSAPI @JohnnyPlayy @MishimaHaruna @dastgirp