Update Sense Skill - show 0 for negative values #2544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable commented out lines that cap negative values to 0 in the Sense window. Currently the client displays them as 255-fix. [Skotlex]
Contributor
|
This change is |
dastgirp
approved these changes
Oct 5, 2019
MishimaHaruna
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Result: Negative values return as 256 - (value).
For instance, Undead Lv1 has -25 against Poison and Shadow, so it shows up as 231:
Expected Result:
Negative values instead return as 0 on kRO:
How to Reproduce:
Use Sense against a monster whose property will absorb any element.
Official Information: Only took Gravity 17 years to fix!
http://ro.gnjoy.com/news/notice/View.asp?seq=7126
Issues addressed:
Merged from rathena/rathena@19835b6