Update dropall atcommand #2545
Merged
Update dropall atcommand #2545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emistry
added
type:enhancement
Contributor
|
This change is |
4144
approved these changes
Oct 3, 2019
Contributor
|
Either I read this wrong or you might have merged it badly. You still access the count inside the inventory after it was deleted... |
Member
|
@Lemongrass3110 is correct |
dastgirp
requested changes
Oct 3, 2019
- The correct amount of dropped items should be displayed. - Included skipped amount.
Emistry
force-pushed
the
atcommand_dropall
branch
from
1249dac to
d37c71d
Compare
dastgirp
approved these changes
Oct 5, 2019
4144
approved these changes
Oct 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Issues addressed:
Merge from rathena/rathena@beb6b57