Dehardcode DB files path #2547
Merged
Dehardcode DB files path #2547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This change is |
guilherme-gm
force-pushed
the
201910-dehardcode-db
branch
4 times, most recently
from
9b19cc5 to
f4d3c2c
Compare
Contributor
|
look like in mapindex.h missing include |
guilherme-gm
force-pushed
the
201910-dehardcode-db
branch
2 times, most recently
from
437b9ac to
04b72bd
Compare
Member
Author
|
Yes, fixed. Thanks! |
4144
requested changes
Oct 5, 2019
guilherme-gm
force-pushed
the
201910-dehardcode-db
branch
from
04b72bd to
2b697b9
Compare
guilherme-gm
force-pushed
the
201910-dehardcode-db
branch
from
2b697b9 to
cd2ad1e
Compare
MishimaHaruna
requested changes
Oct 19, 2019
A new config file "conf/common/map-index.conf" is added to set the file path
guilherme-gm
force-pushed
the
201910-dehardcode-db
branch
from
cd2ad1e to
be955e5
Compare
MishimaHaruna
approved these changes
Oct 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
This pull request aims at dehardcoding all
db/*file paths, allowing users to change which folder to load the database files from. It applies to all files used by char and map servers.For char-server, the
db_pathglobal variable inchar.cgot moved to thechrinterface inchar.hso it is possible to use it in other files.Issues addressed:
None, as far as I know
Special thanks to @4144 for giving me some ideas