Skip to content

Conversation

@bWolfie
Copy link
Contributor

@bWolfie bWolfie commented Oct 4, 2019

Pull Request Prelude

Changes Proposed

This fixes @fakename display. Currently it only displays if you have a disguise active.
Proposed changed = only shows when you don't have disguise active. Although, my personal opinion is there should be no check for disguise.

This one needs some clarification. Previously we did not check for sd->disguise in relation to fake names. Was there a report that said @fakename has some issues?

Issues addressed:
#2539

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@bWolfie bWolfie changed the base branch from stable to master October 4, 2019 12:02
@4144
Copy link
Contributor

4144 commented Oct 5, 2019

you checked how it works if disquise enabled?

@bWolfie
Copy link
Contributor Author

bWolfie commented Oct 6, 2019

you checked how it works if disquise enabled?

Yep works fine with disguise. I tried doing all sorts, like undisguising with fakename active, using fakename after activating disguise and so on.

@hemagx
Copy link
Contributor

hemagx commented Oct 12, 2019

I think the change from the original commit was done by mistake, the original commit clearly says

Send old name packet for players if fake name or disguise used

so i believe the fix shall be by replacing && with || and not just remove it.

The original commit that introduced the change: e68011e

Copy link
Contributor

@hemagx hemagx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly check my comment regard commit e68011e

@MishimaHaruna MishimaHaruna merged commit 76c5cbe into HerculesWS:master Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants